fix create_minor_version.sh and update README #16769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/S
zirain
commented
Aug 11, 2025
| @@ -149,9 +149,9 @@ parse_versions() { | |||
|
|
|||
| step0() { | |||
| echo -e "\nStep 0: Check and prepare the environment\n" | |||
| parse_input "$1" | |||
There was a problem hiding this comment.
to prevent:
+ echo 'DRY_RUN: _gitpush origin master'
DRY_RUN: _gitpush origin master
+ gh repo set-default ''
expected the "[HOST/]OWNER/REPO" format, got ""
+ cleanup_env
+ popd
There was a problem hiding this comment.
will gh repo accept user/istio.io.git as a repo format?
There was a problem hiding this comment.
This is already being done in #16770. And yes Craig, it will. Mentioned in the thread I was going to fix them in the master bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dhawton @craigbox